Drop no-longer-used isort configuration#663
Merged
pradyunsg merged 1 commit intopythonindia:masterfrom Apr 5, 2020
pradyunsg:drop-no-used-isort-config
Merged
Drop no-longer-used isort configuration#663pradyunsg merged 1 commit intopythonindia:masterfrom pradyunsg:drop-no-used-isort-config
pradyunsg merged 1 commit intopythonindia:masterfrom
pradyunsg:drop-no-used-isort-config
Conversation
Contributor
Author
|
Merging since this is clearly non controversial IMO |
Contributor
|
@pradyunsg A bunch of isort tests failed after this change. Those are caused due to alphabetical order of the orders. Now the order of thirdparty libs is not maintained. Looks like we need these 2 settings in setup.cfg to fix the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.